Metadata
- Source
- FLOE-339
- Type
- Task
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Justin Obara
- Reporter
- Simon Bates
- Created
2015-05-14T17:15:18.238-0400 - Updated
2015-11-03T12:09:50.740-0500 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- First Discovery
Description
Update the self voicing for the Sticky Keys simulation to indicate when shift is turned off.
For FLOE-312 we implemented a spoken message when shift is turned on. We should also add a message when shift is turned off:
"shift is off"
This message should only be spoken when shift is turned off due to pressing shift again without inputting a keypress. Shift is also unlatched when we generate a shifted keypress, but we don't want to speak the "shift is off" message in this case.
Comments
-
Antranig Basman commented
2015-05-25T17:10:07.485-0400 This looks like a use case which motivates restoring the "source tracking" system as suggested in http://issues.fluidproject.org/browse/FLUID-5490 . With this, it would be possible to apply a source named "latch" to the shift key source, and then apply 'includeSource: "latch"' to the model listener which provides the spoken message. As it stands, it is awkward to demultiplex the different sources of change to the shift state.
One approach for finessing this for now could be to add a single event source, "shiftLatchChange" which detects the user's long-pressing of shift, and then two add two listeners to this with different priorities - a high priority listener which updates the model state, and then a low priority listener which READS the updated model state and then announces it.
-
Justin Obara commented
2015-05-26T10:41:03.986-0400 Submitted a pull request:
https://github.com/fluid-project/first-discovery/pull/62 -
Cindy Li commented
2015-05-26T15:03:46.711-0400 Merged @ 4b81887c85848fb35b327f42aa348c48bd03c2f9