FLUID-1976: "Add More" button is still active during upload in Flash 9 version

Description

"Add More" button is still active during upload in Flash 9 version

Steps to reproduce:

1) Open the uploader demo:
http://build.fluidproject.org/fluid/fluid-components/html/templates/Uploader.html

2) Add some files to the file queue.

3) Click "upload" to start uploading the files

4) While the files are uploading, click "Add More'

Notice that the OS File Open Dialog appears and you can add more files to the queue, while other files are still uploading

Environments

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
FF2, FF3, IE7, Opera 9.5 (Win XP)
FF3, IE7 (Win Vista)

Attachments

• FLUID-1976.a.patch
• FLUID-1976-isUploading-fix.patch

Comments

• Justin Obara commented 2008-12-15T16:08:52.000-0500

  Bug Parade: 0.6 release

• Eli Cochran commented 2008-12-15T17:00:11.000-0500

  I have added a check inside SWFUploadManager to check that.queue.isUploading before doing a browse. Could probably do a little better on the styling in this case but this'll do for now.

• Colin Clark commented 2008-12-15T19:13:29.000-0500

  I've reviewed Eli's fix and it looks good.

• Eli Cochran commented 2008-12-15T19:26:08.000-0500

  Nice, clean and simple code fix

• Colin Clark commented 2008-12-15T19:42:11.000-0500

  There was a second aspect to this fix that became clear after more testing: the Add more button wasn't working after an upload had been completed. This is because SWFUPloadManager wasn't setting isUploading to false when an upload batch is finished. Here's a patch with a two-line fix.

• Justin Obara commented 2008-12-18T11:13:39.000-0500

  Verified fix using:

  FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
  FF2, FF3, Opera 9.5 (Win XP)
  FF3 (Win Vista)