FLUID-2008: Focus does not remain on Upload/Stop Upload button after activating it with the keyboard

Description

Focus does not remain on Upload/Stop Upload button after activating it with the keyboard

Steps to reproduce:

1) Open the demo version of uploader
http://build.fluidproject.org/fluid/fluid-components/html/templates/Uploader.html

2) Add some files to the file queue

3) Using the keyboard, tap the 'tab' key until the "Upload" button has focus

4) Using the keyboard, tap the 'enter' key to activate the button

Notice that focus isn't on the "Stop Upload" button. The same thing happens after activating the "Stop Upload" button

Environments

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
FF2, FF3, Opera 9.5 (Win XP)
FF3 (Win Vista)

Attachments

• FLUID-2008.a.patch
• FLUID-2008.b.patch

Comments

• Justin Obara commented 2009-02-06T12:55:53.000-0500

  Bug Parade 0.8 release

• Eli Cochran commented 2009-02-12T18:13:48.000-0500

  In reference to the FLUID-2008.a.patch

  • Added new options for elements to be selected on certain events
  • Added new listeners or new code to existing listeners for those events to set the focus on those events
  • Also needed to add a fire event for the onUploadStop event to DemoUploadManager.js

• Eli Cochran commented 2009-02-13T16:41:56.000-0500

  The FLUID-2008.b.patch replaces the .a patch. I have updated the name of the option to focusWithEvent and added a comment so that it doesn't seem automagical

• Colin Clark commented 2009-02-16T21:16:26.000-0500

  I've reviewed Eli's patch and it looks great. +1. We discussed this issue in depth in the IRC room. Here's a link to the transcript:

  http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2009-02-13

  I made a minor change to Eli's comment above focusWithEvent, and will commit this patch.

• Colin Clark commented 2009-02-16T21:19:07.000-0500

  I reviewed, tested, and committed Eli's FLUID-2008.b.patch. Looking good.

• Justin Obara commented 2009-02-16T22:34:08.000-0500

  Verified fix using:

  FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
  FF3 (Win XP)