FLUID-2367: UI Enhancer removes FSS font-size classes.

Metadata

Source
FLUID-2367
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Jacob Farber
Reporter
Michelle D'Souza
Created
2009-03-17T12:24:23.000-0400
Updated
2009-03-25T10:26:46.000-0400
Versions
  1. 1.0
Fixed Versions
  1. 1.0
Component
  1. UIEnhancer

Description

Before applying the appropriate styling, UI Enhancer removes the existing styling. This is the correct behaviour when it comes to things like font style however, font sizes should be left alone.

Comments

  • Justin Obara commented 2009-03-20T12:31:56.000-0400

    Bug Parade 1.0 release

  • Michelle D'Souza commented 2009-03-21T21:24:43.000-0400

    The classes that need to be cleared are the ones in the UIEnhancer's classname map for settings which are applied to the container. Currently these settings are: font face, text spacing, theme, layout and background images. The classes need to be cleared from the entire contents of the container - not just from the container itself.

  • Michelle D'Souza commented 2009-03-22T18:36:56.000-0400

    I just realized that there are probably several FSS classes that will cause clashes that haven't been removed. Jacob, can you determine what these are and add them to the classnameMap in UIEnhancer?

  • Michelle D'Souza commented 2009-03-24T10:31:42.000-0400

    Thanks Jacob for reviewing the FSS clashing classes and adding the missing ones. I reviewed you commit. Commit revisions 6801 and 6806 still need to be reviewed.

  • Jacob Farber commented 2009-03-24T10:50:18.000-0400

    Ok, 6801 and 6806 have been reviewed and they look good.

  • Justin Obara commented 2009-03-25T10:26:46.000-0400

    there are no current implementations to test this against, closed based on code review