FLUID-3793: columnDefs = "explode" causes error

Description

If the Pager's default columnDefs value of "explode" is used, an error is thrown on line 535. The call to getRoots() on line 533 assumes a return value, but getRoots() doesn't return anything - it modifies the first argument. The fix is simple, but we need a test that catches it.

Attachments

• FLUID-3793.patch.proper-paths.txt
• FLUID-3793.patch.txt

Comments

• Anastasia Cheetham commented 2010-10-12T13:24:08.861-0400

  Justin, since this is a bug caused by the default configuration (and since the fix is reasonably simple), I filed this as a blocker for 1.3. If you concur, feel free to assign it back to me and I'll commit a test and a fix asap.

• Justin Obara commented 2010-10-12T14:08:34.260-0400

  "Bug Parade Infusion 1.3"

• Anastasia Cheetham commented 2010-10-12T14:41:15.773-0400

  This patch (FLUID-3793.patch.txt) adds a test that configures the pager to use the fluid.pager.selfRender body renderer with the default columnDefs of "explode", which causes an error without the fix to the Pager. The fix to the pager (also included in this patch) is to use getRoots() properly, i.e. to use the modified first argument instead of a return value (there is no return value).

• Anastasia Cheetham commented 2010-10-19T09:11:15.032-0400

  Antranig, could you review this patch? It adjusts the code to the existing apparent usage of the function, but the api of the function might actually be wrong given the name? A "get" function that doesn't actually get anything? I wonder if either the name should be changed or the function should return something?

• Antranig Basman commented 2010-10-28T16:43:26.472-0400

  Hi Anastasia - this patch looks ok in content, but seems to have been generated in a strange way that does not include file paths. Would it be possible for you to regenerate it?

• Anastasia Cheetham commented 2010-10-28T16:48:56.370-0400

  Adding another attempt at the same patch, but with proper file paths.

• Antranig Basman commented 2010-10-28T16:56:08.875-0400

  Reviewed and applied at rev 10165