FLUID-5320: "getLineHeight without IE simulation" enactor unit test fails in IE

Metadata

Source
FLUID-5320
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Justin Obara
Created
2014-04-25T11:57:52.949-0400
Updated
2014-04-29T10:36:10.955-0400
Versions
N/A
Fixed Versions
  1. 1.5
Component
  1. Prefs Framework

Description

Steps to reproduce:

1) Run the Enactor unit tests
http://build.fluidproject.org/infusion/src/tests/framework-tests/preferences/html/Enactors-test.html

2) notice that the getLineHeight tests are failing on "getLineHeight without IE simulation"

Environments

IE 8, 9, 10, 11

Comments

  • Justin Obara commented 2014-04-25T12:00:54.947-0400

    The cause of the issues seems to be that IE reports the multiplier value as opposed to the line height in px values. In IE 10 and 11, the px value is reported when using jQuery's "css" method, however IE 8 and 9 still report the same value as sourced from the currentStyle property.

    One possible solution will be to combine getLineHeight and numerizeLineHeight into a single method that just gets the multiplier value directly.

  • Justin Obara commented 2014-04-25T14:47:12.829-0400

    Submitted a pull request https://github.com/fluid-project/infusion/pull/499

  • Cindy Li commented 2014-04-29T10:36:08.377-0400

    Merged into the project repo @ cc8d78b3c82b968849335ee3da524fe3b2cb9cda