Metadata
- Source
- FLUID-5480
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Kasper Galschiot Markus
- Reporter
- Antranig Basman
- Created
2014-07-23T17:06:22.690-0400 - Updated
2024-07-22T10:35:27.658-0400 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- Model Transformation System
Description
We need to standardise on a symmetric convention for this. Similar to the situation with "input" and "value" in the standard transforms, we have ended up with a system which is inconsistent since the names used cannot be directly predicted for the inverse of the same transform. We should probably rename "inputPath" to "defaultInputPath". This actually caused a bug in the inverse transform which affected the FLUID-5479 work
Comments
-
Antranig Basman commented
2014-07-23T18:46:07.886-0400 Also, the mere requirement for "inputPath" as mandatory is confusing to users, especially in the context of model relay rules. If
inputPath: ""
is not specified, the transform will do nothing
-
Antranig Basman commented
2015-05-12T15:41:41.912-0400 In addition, the valueMapper should default to a "defaultInputPath" of "" (the empty string) since this is overwhelmingly the expected case when writing relay rules.
-
Kasper Galschiot Markus commented
2016-04-06T11:22:52.864-0400 The part related to the input paths "" as mentioned in the comments above by Antranig Basman should be done via FLUID-5357 which aims for this to be fixed as a general framework feature.
If the valueMapper should follow the standard semantics of the Model Transformation framework input-wise, the naming should probably be 'input' and 'inputPath'. In terms of defaultOutputPath, this is something we would need to figure out
-
Kasper Galschiot Markus commented
2016-09-13T03:41:40.505-0400 Given that the input path "" part of this jira is covered via FLUID-5357. Do you think this can be closed by the clarified semantics in the new valuemapper?
-
Kasper Galschiot Markus commented
2016-10-26T09:23:59.417-0400 The confusion of the naming has been fixed here: https://github.com/fluid-project/infusion/pull/710 ... the inputPath: "" is covered by FLUID-5357