FLUID-5639: 404 error page has hardcoded path to CSS and Favicon which breaks self-contained nature of the source

Metadata

Source
FLUID-5639
Type
Bug
Priority
Major
Status
Closed
Resolution
Cannot Reproduce
Assignee
N/A
Reporter
Jonathan Hung
Created
2015-04-20T15:02:24.030-0400
Updated
2022-03-14T12:43:41.880-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Tech. Documentation

Description

The 404.html page in the Infusion Docs has a hard coded path to the favicon and the fluid-docs.css file. This allows the 404 page to look proper when served from the docs.fluidproject.org domain, but this breaks the self-contained nature of the source which doesn't assume any paths (everything should be relative).

The core issue is that github delivers the 404.html page in place of the requested document. If a relative path is used in the 404.html file, the path is relative to the requested document, not the 404.html file located in the root. It is this same reason the 404.html page links to a CDN version of Foundation and not the local copy.

Comments

  • Justin Obara commented 2022-03-14T12:43:41.869-0400

    This doesn't appear to be causing any issues with the current 11ty based site hosted on netlify.