Metadata
- Source
- FLUID-6268
- Type
- Bug
- Priority
- Major
- Status
- Closed
- Resolution
- Fixed
- Assignee
- N/A
- Reporter
- Mike Gifford
- Created
2018-03-29T13:23:00.382-0400 - Updated
2024-07-24T12:55:04.440-0400 - Versions
-
- 3.0
- Fixed Versions
- N/A
- Component
-
- Framework
Description
In the demo here we set up http://test-cela.pantheonsite.io/
The page resize doesn't work properly in FF. Similar isssue with line heights.
Environments
Drupal 8
Comments
-
Justin Obara commented
2018-04-03T13:29:33.543-0400 Regarding the line-height. Unfortunately the line spacing enactor isn't able to adjust the line-height for nested elements which already have their line-height set. See FLUID-4491.
For the fontsize, if an element is set with a size in px it will not be resized. Only values set with relative sizes e.g. em, rem will be resized. Is there a specific element you can point us at that should resize but isn't?
-
Mike Gifford commented
2018-04-03T13:43:18.515-0400 Thanks Justin.
Interesting to think about the nested elements with line-height.
Not using pixels.. Good reminder, but interesting that it limits things like this. Makes sense as it isn't relative.
Are these written up somewhere? Would be great to be able to review to see that best practices are followed and which ones actually matter for this widget.
-
Justin Obara commented
2018-04-04T09:30:23.127-0400 Mike Gifford I think this tutorial will help a bit
There are other tutorials there that might help with other aspects, including some on contrast.
-
Justin Obara commented
2024-07-24T12:55:04.440-0400 While the adjustments had been working as designed, css custom properties have been added and can be hooked into to allow for more integrator controlled adjustments.