SJRK-123: Set hasMobileCamera to true for image block editor tests

Metadata

Source
SJRK-123
Type
Task
Priority
Major
Status
Closed
Resolution
Done
Assignee
N/A
Reporter
Gregor Moss
Created
2018-06-01T13:51:06.523-0400
Updated
2018-06-04T15:34:59.936-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Storytelling Tool UI

Description

On a desktop browser, the imageCaptureButton does not appear because of the context-awareness setup. However, the tests are not dependent on an actual working mobile camera or similar, so we should (for testing purposes) simply set the "hasMobileCamera" context to true so these tests will run and confirm what can be confirmed with automated testing.

Relevant lines at 68-75 of imageBlockEditor tests, currently commented out:

{
   jQueryTrigger: "click",
   element: "{imageBlock}.dom.imageCaptureButton"
}, {
   event: "{imageBlock}.events.imageCaptureRequested",
   listener: "jqUnit.assert",
   args: ["The imageUploadRequested event fired"]
}

Comments

  • Gregor Moss commented 2018-06-04T15:34:59.933-0400

    hasMobileCamera was included by overriding the check function with a function that only returns true, this way the contextAwareness is still used and tested